refactor(click-to-pay): extract parsers, scripts, and webview management#115
Open
manideepk90 wants to merge 1 commit into
Open
refactor(click-to-pay): extract parsers, scripts, and webview management#115manideepk90 wants to merge 1 commit into
manideepk90 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Summary
Extract three major concerns from
DefaultClickToPaySessionLauncherinto separate files for bettermaintainability and testability:
1. JSON Parsing (
ClickToPayResponseDecoder.kt)JSONObject/JSONArrayparsing logicDecodeResult<T>sealed class for proper error handling2. JavaScript Code (
ClickToPayScripts.kt)3. WebView Lifecycle (
ClickToPayWebViewManager.kt)ConcurrentHashMapMutex-based synchronization for lifecycle operationsBenefits
DefaultClickToPaySessionLauncherfrom 1,272 to 837 lines (34% reduction)DecodeResult<T>Bug Fixes Applied During Refactor
evaluateJavascriptOnMainThread- was ignoring passedrequestIdandcreating new one, causing hangs
"compactability"→"always"Verification
requestIdcorrectlyFiles Changed
ClickToPayResponseDecoder.ktClickToPayScripts.ktClickToPayWebViewManager.ktDefaultClickToPaySessionLauncher.ktAffected Area & Impact
Testing
./gradlew :hyperswitch-sdk-android-click-to-pay:compileDebugKotlin)Checklist